[WIP] Add visibility filter #17
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code clean
README.md
Outdated
|
|
||
| Go on https://github.com/splitsh/lite/releases to chose a version |
There was a problem hiding this comment.
Suggested change
| Go on https://github.com/splitsh/lite/releases to chose a version | |
| Go on [splitsh](https://github.com/splitsh/lite/releases) to choose a version |
| @@ -226,7 +234,7 @@ public function getContentTypeList(): array | |||
| $contentTypesMap[ucfirst($contentType->getName())] = $contentType->id; | |||
| } | |||
| ksort($contentTypesMap); | |||
| if (\count($contentTypesMap)) { | |||
There was a problem hiding this comment.
Why do we leave the '' here?
Why don't we put it for the ksort function right on top?
How about an import?
There was a problem hiding this comment.
Seb shared an article that using \ was quicker to resolve by the PHP
There was a problem hiding this comment.
it is and PHP Storm EAD Inspections (that you should have) is supposed to show it too ;-)
|
It sounds good, still in Draft for a reason @RemyNovactive ? Thanks both of you cc @anaelChardan |
Plopix
force-pushed
the
master
branch
2 times, most recently
from
3fee25a
to
6d420fe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a visibility filter to be sure of fetch only visible content.